Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prevent adding children to synonym nodes when not authorized #4874

Merged
merged 13 commits into from
May 21, 2024

Conversation

CarolineDenis
Copy link
Contributor

@CarolineDenis CarolineDenis commented May 2, 2024

Fixes #4868

Checklist

  • Self-review the PR after opening it to make sure the changes look good
    and self-explanatory (or properly documented)
  • Add relevant issue to release milestone

Testing instructions

Note: Remote Preferences should not have the line: sp7.allow_adding_child_to_synonymized_parent.TREENAME=true
If it does, set it =false or delete the line, then clear your cache.

@CarolineDenis CarolineDenis added this to the 7.9.6 milestone May 7, 2024
@CarolineDenis CarolineDenis marked this pull request as draft May 7, 2024 14:55
@CarolineDenis CarolineDenis marked this pull request as ready for review May 9, 2024 12:21
@CarolineDenis CarolineDenis requested a review from a team May 9, 2024 12:21
Copy link
Collaborator

@emenslin emenslin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Testing instructions

Note: Remote Preferences should not have the line: sp7.allow_adding_child_to_synonymized_parent.TREENAME=true
If it does, set it =false or delete the line, then clear your cache.

Looks good, cannot add a child to a synonymized node
Screenshot 2024-05-13 103910

@emenslin emenslin requested a review from a team May 13, 2024 15:44
Copy link
Collaborator

@combs-a combs-a left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Testing Instructions

13_synchildtest.mp4

Looks good, blocked it correctly. Good work!

@CarolineDenis CarolineDenis merged commit dfb16cb into production May 21, 2024
9 checks passed
@CarolineDenis CarolineDenis deleted the issue-4868 branch May 21, 2024 15:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

Error when adding child to Synonymized node
4 participants