Open interaction dialog when adding prep in ExchangeOut

[CarolineDenis]

Fixes #922

Checklist

• Self-review the PR after opening it to make sure the changes look good
  and self-explanatory (or properly documented)
• Add relevant issue to release milestone

Testing instructions

• Go to interactions
• Open Exchange Out
• Add a prep
• verify the interaction dialog opens
• verify that you can add a prep by selecting "By choosing a record set"
• verify that you can add a prep by selecting "By entering catalog number"
• verify that you can add an unassociated item
• test adding a preparation for ExchangeIn

[melton-jason]

Currently, ExchangeOut is not the only Interaction missing a dialog: ExchangeIn is missing one as well!

I have some suggestions to make our current approach more generic without relying on hardcoding the tables which are supported.

[emenslin]

Testing instructions

• Go to interactions
• Open Exchange Out
• Add a prep
• verify the interaction dialog opens
• verify that you can add a prep by selecting "By choosing a record set"
• verify that you can add a prep by selecting "By entering catalog number"
• verify that you can add an unassociated item
• test adding a preparation for ExchangeIn

There is no option for adding an unassociated item when creating an exchange in/out, only in the add items dialog.

Also although you can add preparations through record set or catalog numbers in the create exchange in/out, when you try to add any items after that it just adds a blank preparation

LK8UmhhIet.mp4

Basically, the initial dialog works aside from missing the add unassociated preps button but the add items dialog will only add blank preparations.

Also side note, the exchange in default form does not include the preparations subview, is there a reason for that?

[melton-jason]

Testing instructions

• Go to interactions
• Open Exchange Out
• Add a prep
• verify the interaction dialog opens
• verify that you can add a prep by selecting "By choosing a record set"
• verify that you can add a prep by selecting "By entering catalog number"
• verify that you can add an unassociated item
• test adding a preparation for ExchangeIn

There is no option for adding an unassociated item when creating an exchange in/out, only in the add items dialog.

Also although you can add preparations through record set or catalog numbers in the create exchange in/out, when you try to add any items after that it just adds a blank preparation

LK8UmhhIet.mp4
Basically, the initial dialog works aside from missing the add unassociated preps button but the add items dialog will only add blank preparations.

Also side note, the exchange in default form does not include the preparations subview, is there a reason for that?

@emenslin

Both of these issues have been fixed.

• All Interactions with Preparations (Disposal, ExchangeIn, ExchangeOut, Gift, Loan) should now have the Without Preparations button when creating the Interaction.
  • Previously only Gift and Loan had the button
• When adding Preparations from the Interaction, it should no longer add empty Interactions.

[emenslin]

Testing instructions

• Go to interactions
• Open Exchange Out
• Add a prep
• verify the interaction dialog opens
• verify that you can add a prep by selecting "By choosing a record set"
• verify that you can add a prep by selecting "By entering catalog number"
• verify that you can add an unassociated item
• test adding a preparation for ExchangeIn

Looks good, the without preparation button is there and it adds items correctly now!

[alesan99]

• verify the interaction dialog opens
• verify that you can add a prep by selecting "By choosing a record set"
• verify that you can add a prep by selecting "By entering catalog number"
• verify that you can add an unassociated item
• test adding a preparation for ExchangeIn

Checks out 👍
I also found it weird that there is no preparation subview in the default Exchange In form, but perhaps that can be addressed elsewhere