Attachment Mapping File Support #4791
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes ##4766
Realized that previously implemented logic covered most of the cases. We already supported matching files to previously selected files. So, now, we just make a new attachment dataset based on the selected csv. When user selects files, they will be matched to this dataset (which is based on csv) so we just preserve the parsed name.
I'll add more automated tests for this before making this open for review for everything seems to be working!
EDIT: I based it off @melton-jason coge-import because I realized I could reuse some of that code. I'm still considering directly using workbench's implementation though
Checklist
and self-explanatory (or properly documented)
Testing instructions