-
Notifications
You must be signed in to change notification settings - Fork 38
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
upgrade requests to 2.32.2 #4772
Conversation
Is this the right link to the dependabot alert? https://github.com/specify/specify7-test-panel/security/dependabot/19 That alert is on the test panel repository, and unrelated to Python and the Both recommend upgrading to |
@melton-jason Looks like version 2.32.0 for the requests module just got pushed two days ago. I'll go ahead update it to 2.32.2 https://pypi.org/project/requests/#history Lol, they yanked 2.32.0 and 2.32.1 releases... we've never done that 😆 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Testing instructions
There is not specific test to perform. Testing for this PR will be covered in the general testing checklist.
For now, test:
- Simple queries work in the QB
- Opening forms work
- Viewing trees work
Collectors and groups subforms are broken again
pySMYEM8Nt.mp4
RHYKUIgz8P.mp4
Looks like this PR was based from an old commit (from April 10) and had not been merged with |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Testing instructions
There is not specific test to perform. Testing for this PR will be covered in the general testing checklist.
For now, test:
- Simple queries work in the QB
- Opening forms work
- Viewing trees work
Looks good!
None of those tests requests explicitly AFAIK.
|
Fixes #4771
Upgrades the python library 'request' from version 2.28.1 to at least version 2.31.0 or later in order to fix the security vulnerability pointed out here
Checklist
and self-explanatory (or properly documented)
Testing instructions
There is not specific test to perform. Testing for this PR will be covered in the general testing checklist.
For now, test: