Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Collection Objects without any current determination can be saved #4819

Open
combs-a opened this issue Apr 22, 2024 · 1 comment · May be fixed by #4901
Open

Collection Objects without any current determination can be saved #4819

combs-a opened this issue Apr 22, 2024 · 1 comment · May be fixed by #4901
Assignees
@CarolineDenis
Labels
1 - Bug Incorrect behavior of the product 2 - Forms Issues that are related to the form system
Milestone
7.9.7

Comments

@combs-a
Copy link
Collaborator

combs-a commented Apr 22, 2024

Describe the bug
When you add and delete a determination, no determination will be current anymore. Present in v7.9.3 as well.

To Reproduce
Steps to reproduce the behavior:

  1. Go to Data Entry->Collection Object
  2. Add multiple determinations
  3. Delete the determination with isCurrent checked
  4. Check the other determinations to see that there is no longer any marked as current
  5. See that you can save

Expected behavior
No behavior was implemented for this previously. Should maybe have a save blocker or something to prevent from saving without a current determination marked? Unsure of the implications of this, but knowing the up-to-date determination seems important.

Screenshots
image

  • OS: Windows 10
  • Browser: Firefox
  • Specify 7 Version: edge
  • Database Name: sdnhm_herps_2_8_24
  • Collection name: Herp-PC
  • User Name: testuser

Specify 7 System Information - 2024-04-22T21 53 37.884Z.txt
@combs-a combs-a added 1 - Bug Incorrect behavior of the product 2 - Forms Issues that are related to the form system labels Apr 22, 2024
@combs-a combs-a added this to the 7.9.4 milestone Apr 22, 2024
@CarolineDenis CarolineDenis modified the milestones: 7.9.4, 7.9.x Apr 23, 2024
@grantfitzsimmons
Copy link
Member

For reference, Specify 6 prevents saving the Collection Object record if there is not a current determination. I would advise taking this approach rather than arbitrarily setting the second determination as "current" so the data is not falsified.

image

@grantfitzsimmons grantfitzsimmons changed the title isCurrent not checked on any determinations after adding and deleting a determination Collection Objects without any current determination can be saved Apr 24, 2024
@CarolineDenis CarolineDenis self-assigned this May 10, 2024
CarolineDenis added a commit that referenced this issue May 10, 2024
@CarolineDenis
Prevent user from saving CO without current determination
c560078 
Fixes #4819
@CarolineDenis CarolineDenis linked a pull request May 10, 2024 that will close this issue
Open
4 tasks
@CarolineDenis CarolineDenis modified the milestones: 7.9.x, 7.9.7 May 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@CarolineDenis CarolineDenis

Labels
1 - Bug Incorrect behavior of the product 2 - Forms Issues that are related to the form system
Projects
None yet
Milestone
7.9.7
Development

Successfully merging a pull request may close this issue.

Prevent user from saving CO without current determination specify/specify7
3 participants
@grantfitzsimmons @combs-a @CarolineDenis