Display create RS and Gallery tool only for factious RS with same type #4904
+22
−5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Triggered by 62c52e1 on branch refs/heads/issue-4898
sharadsw
reviewed
May 10, 2024
sharadsw
approved these changes
May 10, 2024
what does Record Cet? |
CarolineDenis
changed the title
Areyes42
requested changes
May 20, 2024
There was a problem hiding this comment.
Testing instructions
- Go to data entry (ex CO)
- save form
- verify that Gallery icon and Create RS tool are not available
- create a new data entry form using the same table as in first step (ex CO)
- verify that Gallery icon and Create RS tool are not available
- save form
- verify that Gallery icon and Create RS tool are available
- create a new data entry form using another table than in first step (ex CE)
- verify that Gallery icon and Create RS tool are not available
- save
- verify that Gallery icon and Create RS tool are not available
Everything looks good, except saving the first CO still shows the Gallery icon as available. Is this intended behavior or a mistake in the testing instruction checklist?
Screen.Recording.2024-05-20.at.3.04.38.PM.mov
|
@Areyes42 , a mistake sorry for that |
Areyes42
approved these changes
May 20, 2024
lexiclevenger
approved these changes
Jun 3, 2024
There was a problem hiding this comment.
Testing instructions
- Go to data entry (ex CO)
- save form
- verify that Create RS tool are not available
- create a new data entry form using the same table as in first step (ex CO)
- verify that Gallery icon and Create RS tool are not available
- save form
- verify that Gallery icon and Create RS tool are available
- create a new data entry form using another table than in first step (ex CE)
- verify that Gallery icon and Create RS tool are not available
- save
- verify that Gallery icon and Create RS tool are not available
Looks good! Everything is behaving according to the instructions.
combs-a
approved these changes
Jun 4, 2024
There was a problem hiding this comment.
- Go to data entry (ex CO)
- save form
- verify that Create RS tool are not available
- create a new data entry form using the same table as in first step (ex CO)
- verify that Gallery icon and Create RS tool are not available
- save form
- verify that Gallery icon and Create RS tool are available
- create a new data entry form using another table than in first step (ex CE)
- verify that Gallery icon and Create RS tool are not available
- save
- verify that Gallery icon and Create RS tool are not available
Looks good, seems to have fixed everything.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #4898
Checklist
and self-explanatory (or properly documented)
Testing instructions