Update jsonschema version to 3.0.1 & JSON Schema draft to 7 #996
Conversation
danie1k
changed the title
danie1k
changed the title
| @@ -151,7 +151,7 @@ def schema_response_integer(valid): | |||
| if valid == "valid": | |||
| return 3 | |||
| else: | |||
| return 3.0 | |||
| return 3.14 | |||
There was a problem hiding this comment.
what's the background of this change?
There was a problem hiding this comment.
Seems that jsonschema draft 7 treats 3.0 as integer; because from a mathematical point of view 3.0 == 3, I think.
I havent search where/when such change has been made in jsonschema.
There was a problem hiding this comment.
Unit tests were failing without that update. And because it looks pretty resonable, I applied that.
There was a problem hiding this comment.
|
the openapi spec is explicitly based on draft 4. |
I didn't know that. What are the reasons for that? |
|
It looks like my response wasn't quite right (sorry I was on mobile). I don't have the details on why, but i do think it's important to follow the spec. |
I assume that there might not be easy way of using two different jsonchema drafts simultaneously?
According to official JSON Schema website, Draft 5 should not be used, so Draft 6 is natural choice then, as a closest next version... But because Draft 7 is is fully backwards-compatible with Draft 6, we should use it, IMO. |
|
There might be one more problem... The p1c2u/openapi-spec-validator package, which is the dependency of Connexion. It looks not very well maintained 🤔 and it still relies on Draft 4. |
|
Such update is far more complex than it looks, more details in #983. |
Fixes #983.
Changes proposed in this pull request:
jsonschemarequirement version to>=3.0.1,4.0.04to7Related Pull Request(s):