Generate examples in MockResolver with JSF library #1870
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@RobbeSneyders I hope that you will be happy to merge this in based on #1718 (comment) Let me know if you have any questions or comments. |
There was a problem hiding this comment.
Thanks @mjp4! This indeed looks like a good way to support example generation.
connexion/operations/openapi.py
Outdated
Comment on lines
215
to
214
| try: | ||
| return generate_example(schema) | ||
| except KeyError: | ||
| raise |
There was a problem hiding this comment.
I don't think the generate_example will raise a KeyError. I think we only need to catch ImportErrors here since the dependency is optional?
Same for swagger2.py.
There was a problem hiding this comment.
Good spot. I've reworked that code to be a bit nicer.
|
You'll need to bump the Can you also add this to the CLI docs? |
|
You'll need to bump |
mjp4
force-pushed
the
generate-examples-with-jsf
branch
from
e45189b
to
88b205f
Compare
mjp4
force-pushed
the
generate-examples-with-jsf
branch
from
a447519
to
994f53f
Compare
RobbeSneyders
added a commit
that referenced
this pull request
Mar 20, 2024
Fixes #1719 . Builds on work of #1718, pulling in external library to provide the fake data from JSON schema. Changes proposed in this pull request: * Use JSF library to generate sample data for mocking APIs without examples. * Add this as a new extra dependency "mock" See discussion on #1870 --------- Co-authored-by: Robbe Sneyders <robbe.sneyders@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1719 .
Builds on work of #1718, pulling in external library to provide the fake data from JSON schema.
Changes proposed in this pull request: