Skip to content

Support multiple packages per SPDX document. #168

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Jun 11, 2021

Conversation

licquia
Copy link
Collaborator

@licquia licquia commented Jun 8, 2021

This set of patches adds support for multiple packages per document, by adding document.packages as an array. The API for managing multiple packages is set up to mimic the other APIs for managing multiple objects (files, external licenses, etc.).

To preserve backwards compatibility, this patch introduces document.package as a property; this property is implemented using document.packages behind the scenes, and triggers a DeprecationWarning.

Support is included for parsing documents with multiple packages, as well as writing such documents.

Fixes #79.

Jeff Licquia added 3 commits June 8, 2021 15:46
Signed-off-by: Jeff Licquia <licquia@linuxfoundation.org>
Signed-off-by: Jeff Licquia <licquia@linuxfoundation.org>
Signed-off-by: Jeff Licquia <licquia@linuxfoundation.org>
Copy link
Member

@pombredanne pombredanne left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LTGM... I am not too worried about the CI hiccups... but let me see how the warning behaves in practice

@pombredanne
Copy link
Member

All good to me. Merging. Thanks!

@pombredanne pombredanne merged commit 1cdbe92 into spdx:master Jun 11, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add support for parsing more than one package
2 participants