Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for Laravel 5.8 #95

Merged
merged 4 commits into from Feb 27, 2019
Merged

Add support for Laravel 5.8 #95

merged 4 commits into from Feb 27, 2019

Conversation

axelitus
Copy link
Contributor

No description provided.

@axelitus
Copy link
Contributor Author

axelitus commented Feb 26, 2019

The change in the TestCase breaks backward compatibility with older versions of PHPUnit because of this commit referenced on this issue.

This change makes the package incompatible with PHPUnit versions older than version 7.4.5 which was released on dec 2.

It also breaks compatibility with orchestral/testbench versions prior to 3.8.0

I'll submit a new commit addressing this.

@axelitus
Copy link
Contributor Author

The tests fail because as of now, although orchestra/testbench is already tagged for version 3.8.0, its requirement orchestra/testbench-core is not.

I've opened an issue already.

@axelitus
Copy link
Contributor Author

Come to think about it, if support for Laravel 5.5 is dropped then it should be a new major release...

Anyways, that is for you to decide 😉

@rubenvanassche rubenvanassche merged commit 117501f into spatie:master Feb 27, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants