Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix clone behavior of QueryBuilder #621

Merged
merged 3 commits into from May 20, 2021
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
10 changes: 10 additions & 0 deletions src/QueryBuilder.php
Expand Up @@ -130,6 +130,16 @@ public function __call($name, $arguments)

return $result;
}

public function clone()
{
return clone $this;
}

public function __clone()
{
$this->subject = clone $this->subject;
}

public function __get($name)
{
Expand Down
29 changes: 29 additions & 0 deletions tests/QueryBuilderTest.php
Expand Up @@ -297,4 +297,33 @@ public function it_does_not_lose_pivot_values_with_belongs_to_many_relation()
$foundTestModel->pivot->location
);
}


/** @test */
public function it_clones_the_subject_upon_cloning()
{
$queryBuilder = QueryBuilder::for(TestModel::class);

$queryBuilder1 = (clone $queryBuilder)->where('id', 1);
$queryBuilder2 = (clone $queryBuilder)->where('name', 'John Doe');

$this->assertNotSame(
$queryBuilder1->toSql(),
$queryBuilder2->toSql()
);
}

/** @test */
public function it_supports_clone_as_method()
{
$queryBuilder = QueryBuilder::for(TestModel::class);

$queryBuilder1 = $queryBuilder->clone()->where('id', 1);
$queryBuilder2 = $queryBuilder->clone()->where('name', 'John Doe');

$this->assertNotSame(
$queryBuilder1->toSql(),
$queryBuilder2->toSql()
);
}
}