Laravel cache adapter #32
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
freekmurze
requested changes
Mar 8, 2024
src/Adapters/LaravelCacheAdapter.php
Outdated
|
|
||
| private const CACHE_KEY_SUFFIX = '_METRICS'; | ||
|
|
||
| private const STORES = [Gauge::TYPE, Counter::TYPE, Histogram::TYPE, Summary::TYPE]; |
There was a problem hiding this comment.
Refactor this to a regular array.
There was a problem hiding this comment.
In fact the rest of the const, can be refactored the regular protected properties as well.
There was a problem hiding this comment.
what do you mean by regular array?
as a property instead of a const?
freekmurze
requested changes
Mar 12, 2024
| @@ -43,4 +43,17 @@ | |||
| * Allow storage to be wiped after a render of data in metrics controller. | |||
| */ | |||
| 'wipe_storage_after_rendering' => false, | |||
|
|
|||
| /** | |||
There was a problem hiding this comment.
Could you make this doc block smaller. Only 1 or 2 sentences. Move the rest of the explanation to a new section in the readme.
|
|
||
| class LaravelCacheAdapter extends InMemory | ||
| { | ||
| protected string $cacheKeyPrefix = 'PROMETHEUS_'; |
There was a problem hiding this comment.
Let's make these values less "screamy" by using a lowercase value.
|
|
||
| protected function cacheKey(string $type): string | ||
| { | ||
| return $this->cacheKeyPrefix.$type.$this->cacheKeySuffix; |
There was a problem hiding this comment.
Use string interpolation here.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a laravel cache adapter, to leverage all of the laravel cache storage implementations.
I manually tested it with the database, redis, file and array drivers.
I'll provide programmatic tests asap, I just need to read up on Pest first.