Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: avoid closing the script tag early by escaping a forward slash #606

Conversation

maartenbreddels
Copy link

Same as jupyter/nbconvert#1665

Requires a new release of nbconvert as well

@pep8speaks
Copy link

Hello @maartenbreddels! Thanks for opening this PR. We checked the lines you've touched for PEP 8 issues, and found:

Line 287:80: E501 line too long (108 > 79 characters)

@mgeier
Copy link
Member

mgeier commented Nov 24, 2021

Thanks for this PR and sorry for my late response!

I played around with this a bit and it turns out that the </script> tag is case-insensitive and that browsers (at least Firefox and Chromium) also have a problem with </script (with a space at the end).

I've created an extended fix in #611 which should cover more cases. Or am I missing something?

@maartenbreddels
Copy link
Author

maartenbreddels commented Nov 25, 2021 via email

@mgeier
Copy link
Member

mgeier commented Nov 30, 2021

Yeah, even better, care to upstream this?

I don't really want to undo your change from jupyter/nbconvert#1665, which isn't wrong and works in most real cases. But if you prefer my solution, you can of course take it and apply it (or parts of it) to your original change.

@mgeier mgeier closed this Nov 30, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants