This repository has been archived by the owner on Oct 18, 2019. It is now read-only.
Security/fix axios vuln #530
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dannypaz
force-pushed
the
security/fix-axios-vuln
branch
from
511392b
to
df470b4
Compare
updated enum to have unknown default value Fix - Error messaging for insufficient funds and filling orders (#522) * added amounts for insufficient funds errors * error logging for filling own order added amounts for insufficient funds errors (#523) updated enum to have unknown default value add command to validate proto file and update circleci to check added run: to circleci command remove unused file s update circle config to install protoc install protoc try to update repos try to fix apt-get add protoc installation for circle ci try new circle setup for protoc added config use unzip instead of tar fix jessie for deps added protoc check for circle ci readd package command and remove apt-get install of protoc stuff all your protoc are belong to us echo bash env echo bash env hail mary use 64 instead run file remove help file Fix/network status slow (#524) * added amounts for insufficient funds errors updated enum to have unknown default value Fix - Error messaging for insufficient funds and filling orders (#522) * added amounts for insufficient funds errors * error logging for filling own order add logs to check time for network status added amounts for insufficient funds errors (#523) updated enum to have unknown default value add command to validate proto file and update circleci to check added run: to circleci command remove unused file s update circle config to install protoc install protoc try to update repos try to fix apt-get add protoc installation for circle ci try new circle setup for protoc added config use unzip instead of tar fix jessie for deps added protoc check for circle ci readd package command and remove apt-get install of protoc stuff all your protoc are belong to us echo bash env echo bash env hail mary use 64 instead run file remove help file fix the way we inflate all block orders add more logging for testing edits to deadline for network status and removed dev logs from active fund calc * added check for deadline params * fix test with market * change from string to number * fix deadline usage in order summary and wallet * fix tests for deadline changes Feature/healthcheck json (#525) * added amounts for insufficient funds errors updated enum to have unknown default value Fix - Error messaging for insufficient funds and filling orders (#522) * added amounts for insufficient funds errors * error logging for filling own order added amounts for insufficient funds errors (#523) updated enum to have unknown default value add command to validate proto file and update circleci to check added run: to circleci command remove unused file s update circle config to install protoc install protoc try to update repos try to fix apt-get add protoc installation for circle ci try new circle setup for protoc added config use unzip instead of tar fix jessie for deps added protoc check for circle ci readd package command and remove apt-get install of protoc stuff all your protoc are belong to us echo bash env echo bash env hail mary use 64 instead run file remove help file Fix/network status slow (#524) * added amounts for insufficient funds errors updated enum to have unknown default value Fix - Error messaging for insufficient funds and filling orders (#522) * added amounts for insufficient funds errors * error logging for filling own order add logs to check time for network status added amounts for insufficient funds errors (#523) updated enum to have unknown default value add command to validate proto file and update circleci to check added run: to circleci command remove unused file s update circle config to install protoc install protoc try to update repos try to fix apt-get add protoc installation for circle ci try new circle setup for protoc added config use unzip instead of tar fix jessie for deps added protoc check for circle ci readd package command and remove apt-get install of protoc stuff all your protoc are belong to us echo bash env echo bash env hail mary use 64 instead run file remove help file fix the way we inflate all block orders add more logging for testing edits to deadline for network status and removed dev logs from active fund calc * added check for deadline params * fix test with market * change from string to number * fix deadline usage in order summary and wallet * fix tests for deadline changes add json flag for healthcheck * use logger instead of console and pretty print it * added log check for healthcheck cli test Version bump/0.7.1 beta (#526) * 0.7.1-beta * broker version change 0.7.1-beta Feature - Add second parameter for range method calls (#529) * added amounts for insufficient funds errors updated enum to have unknown default value Fix - Error messaging for insufficient funds and filling orders (#522) * added amounts for insufficient funds errors * error logging for filling own order added amounts for insufficient funds errors (#523) updated enum to have unknown default value add command to validate proto file and update circleci to check added run: to circleci command remove unused file s update circle config to install protoc install protoc try to update repos try to fix apt-get add protoc installation for circle ci try new circle setup for protoc added config use unzip instead of tar fix jessie for deps added protoc check for circle ci readd package command and remove apt-get install of protoc stuff all your protoc are belong to us echo bash env echo bash env hail mary use 64 instead run file remove help file Fix/network status slow (#524) * added amounts for insufficient funds errors updated enum to have unknown default value Fix - Error messaging for insufficient funds and filling orders (#522) * added amounts for insufficient funds errors * error logging for filling own order add logs to check time for network status added amounts for insufficient funds errors (#523) updated enum to have unknown default value add command to validate proto file and update circleci to check added run: to circleci command remove unused file s update circle config to install protoc install protoc try to update repos try to fix apt-get add protoc installation for circle ci try new circle setup for protoc added config use unzip instead of tar fix jessie for deps added protoc check for circle ci readd package command and remove apt-get install of protoc stuff all your protoc are belong to us echo bash env echo bash env hail mary use 64 instead run file remove help file fix the way we inflate all block orders add more logging for testing edits to deadline for network status and removed dev logs from active fund calc * added check for deadline params * fix test with market * change from string to number * fix deadline usage in order summary and wallet * fix tests for deadline changes Feature/healthcheck json (#525) * added amounts for insufficient funds errors updated enum to have unknown default value Fix - Error messaging for insufficient funds and filling orders (#522) * added amounts for insufficient funds errors * error logging for filling own order added amounts for insufficient funds errors (#523) updated enum to have unknown default value add command to validate proto file and update circleci to check added run: to circleci command remove unused file s update circle config to install protoc install protoc try to update repos try to fix apt-get add protoc installation for circle ci try new circle setup for protoc added config use unzip instead of tar fix jessie for deps added protoc check for circle ci readd package command and remove apt-get install of protoc stuff all your protoc are belong to us echo bash env echo bash env hail mary use 64 instead run file remove help file Fix/network status slow (#524) * added amounts for insufficient funds errors updated enum to have unknown default value Fix - Error messaging for insufficient funds and filling orders (#522) * added amounts for insufficient funds errors * error logging for filling own order add logs to check time for network status added amounts for insufficient funds errors (#523) updated enum to have unknown default value add command to validate proto file and update circleci to check added run: to circleci command remove unused file s update circle config to install protoc install protoc try to update repos try to fix apt-get add protoc installation for circle ci try new circle setup for protoc added config use unzip instead of tar fix jessie for deps added protoc check for circle ci readd package command and remove apt-get install of protoc stuff all your protoc are belong to us echo bash env echo bash env hail mary use 64 instead run file remove help file fix the way we inflate all block orders add more logging for testing edits to deadline for network status and removed dev logs from active fund calc * added check for deadline params * fix test with market * change from string to number * fix deadline usage in order summary and wallet * fix tests for deadline changes add json flag for healthcheck * use logger instead of console and pretty print it * added log check for healthcheck cli test Version bump/0.7.1 beta (#526) * 0.7.1-beta * broker version change 0.7.1-beta allow parameters for range call fixed variables for start finish * rename rangeForBlockOrder to rangeForBlockOrderIds * comment change of of update pm2 to resolve axios vuln fix
dannypaz
force-pushed
the
security/fix-axios-vuln
branch
from
df470b4
to
b89bc99
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR fixes a security vuln with axios (introduced from our dependency on PM2).
Changes
Related PRs
Axios update for pm2 keymetrics/pm2-io-js-api#65
Axios update axios/axios#2183
Todos