Skip to content
This repository has been archived by the owner on Oct 18, 2019. It is now read-only.

Feature - Add bitcoind/litecoind support to broker #265

Merged
merged 18 commits into from Nov 5, 2018
Merged

Conversation

dannypaz
Copy link
Contributor

@dannypaz dannypaz commented Oct 22, 2018

Description

This adds litecoind/bitcoind support to the broker in the form of build commands.

npm run build local - simnet setup w/ btcd/ltcd
npm run build - user defined (user must edit their own .env files)

All currency networks, other than simnet, make use of bitcoind/litecoind.

BREAKING CHANGE:

This PR may have unintended consequences when a user upgrades. This PR changes the default currency daemons from btcd/ltcd to bitcoind/litecoind.

Tasks:

  1. Backup user wallet
  2. start bitcoind/litecoind and let them sync to testnet
  3. Remove blocks directory from lnd
  4. Start docker-compose up -d

More information will be posted in changelog

Related PRs

sparkswap/lnd-engine#102
sparkswap/lnd-engine#100
https://github.com/sparkswap/relayer/pull/169
sparkswap/lnd#15

Todos

  • [n/a] Tests
  • Documentation
  • Link to Trello

@dannypaz
Copy link
Contributor Author

.env-mainnet-sample Outdated Show resolved Hide resolved
docker-compose.yml Outdated Show resolved Hide resolved
docker-compose.yml Outdated Show resolved Hide resolved
docker-compose.yml Outdated Show resolved Hide resolved
scripts/build.sh Outdated Show resolved Hide resolved
scripts/build.sh Outdated Show resolved Hide resolved
@treygriffith
Copy link
Member

This is a pretty significant breaking change and for anyone that has a broker running will require pretty big changes (including re-syncing, etc).

Can we note this as a breaking change somewhere and include some migration documentation?

@dannypaz
Copy link
Contributor Author

dannypaz commented Oct 23, 2018

@treygriffith The changes should be minimal and should not require a lot of downtime. Im hesitant to call this a major breaking change.

In the best-case scenario, the nodes for currencies (bitcoind/litecoind) should be interchangable as LND owns the wallet. You'll only be required to startup the bitcoind/litecoind nodes, get them synced, then change the docker config and you should be all set.

Now in our case, if we swapped the instances, I would probably expect LND to yell about "Block out of order" and we'd have to remove the blocks folder from LND.

Either way, we will figure out a migration plan.

.env-regtest-sample Outdated Show resolved Hide resolved
Copy link
Member

@treygriffith treygriffith left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM as soon as we have migration docs

@dannypaz dannypaz merged commit 83291a6 into master Nov 5, 2018
@dannypaz dannypaz deleted the feature/bitlitd branch November 5, 2018 18:04
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants