Fix typos #3166
Merged
Fix typos #3166
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
test/files/tlm.html
Outdated
There was a problem hiding this comment.
Should this file have been changed? It's not obvious to me what is being changed here.
There was a problem hiding this comment.
Agree, this file should not be changed, it's an artifact used by tests.
test/helper.rb
Outdated
| @@ -154,7 +154,7 @@ def initialize_nokogiri_test_gc_level | |||
| GC.compact | |||
| rescue NotImplementedError | |||
| @@gc_level = "normal" | |||
| warn("#{__FILE__}:#{__LINE__}: GC compaction not suppport by platform") | |||
| warn("#{__FILE__}:#{__LINE__}: GC compaction not support by platform") | |||
There was a problem hiding this comment.
Perhaps this should be "supported"
| public static class NokogiriXInlcudeEntityResolver implements org.xml.sax.EntityResolver { | ||
| public static class NokogiriXIncludeEntityResolver implements org.xml.sax.EntityResolver { |
There was a problem hiding this comment.
I'm not sure what, if any, impact changing the name of this public class has so I just thought I'd note it.
There was a problem hiding this comment.
This class is commented out since f73bd4e (2017-02-15) so no worries about this change.
flavorjones
requested changes
Apr 7, 2024
test/files/tlm.html
Outdated
There was a problem hiding this comment.
Agree, this file should not be changed, it's an artifact used by tests.
test/helper.rb
Outdated
| @@ -154,7 +154,7 @@ def initialize_nokogiri_test_gc_level | |||
| GC.compact | |||
| rescue NotImplementedError | |||
| @@gc_level = "normal" | |||
| warn("#{__FILE__}:#{__LINE__}: GC compaction not suppport by platform") | |||
| warn("#{__FILE__}:#{__LINE__}: GC compaction not support by platform") | |||
flavorjones
approved these changes
Apr 10, 2024
|
🥳 🥳 🥳 🥳 🥳 |
Merged
flavorjones
added a commit
that referenced
this pull request
May 16, 2024
**What problem is this PR intended to solve?** Fix various typos - some found via `codespell` and `typos` CLI (h/t @kianmeng with PR #3166) **Have you included adequate test coverage?** This PR does not change test coverage - existing tests should suffice. **Does this change affect the behavior of either the C or the Java implementations?** This PR does not introduce any changes in behavior.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What problem is this PR intended to solve?
Fix typos found via
codespell -S test,tmp,ports,coverage,googletest -L te,reencode,ocurandtypos --format briefHave you included adequate test coverage?
Existing tests are sufficient.
Does this change affect the behavior of either the C or the Java implementations?
Nope.