Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Migrate Nokogiri::XML::Document to the TypedData API #2807

Merged
merged 4 commits into from Mar 5, 2023
Merged

Migrate Nokogiri::XML::Document to the TypedData API #2807

merged 4 commits into from Mar 5, 2023

Commits on Mar 3, 2023

  1. Use TypedData for Nokogiri::XML::Document 

    Co-authored-by: Jean Boussier <jean.boussier@gmail.com>
    @etiennebarrie @byroot @flavorjones
    2 people authored and flavorjones committed Mar 3, 2023
    Configuration menu
    Copy the full SHA
    cb1557d View commit details
    Browse the repository at this point in the history

  2. Define a memsize for noko_xml_document_data_type 

    Co-authored-by: Jean Boussier <jean.boussier@gmail.com>
    @etiennebarrie @byroot @flavorjones
    2 people authored and flavorjones committed Mar 3, 2023
    Configuration menu
    Copy the full SHA
    9208336 View commit details
    Browse the repository at this point in the history

  3. ext: don't use FREE_IMMEDIATELY with XML::Document 

    This is a tricky one to explain, but in summary, when dealloc_node_i2
parents unparented nodes, libxml2 may merge two adjacent text nodes,
which causes additional memory allocations during GC.

If the FREE_IMMEDIATELY flag is set, this will generate warnings. But
generating those warnings during GC will lead to a segfault for
reasons I haven't dug into yet.

Anyway, let's leave this flag off for now.
    @flavorjones
    flavorjones committed Mar 3, 2023
    Configuration menu
    Copy the full SHA
    0804380 View commit details
    Browse the repository at this point in the history

Commits on Mar 5, 2023

  1. ext: improve fidelity of XML::Document memsize 

    and include test coverage for it
    @flavorjones
    flavorjones committed Mar 5, 2023
    Configuration menu
    Copy the full SHA
    6b23461 View commit details
    Browse the repository at this point in the history