fix: serialization with pseudo-IO objects like Zip::OutputStream #2775
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
flavorjones
force-pushed
the
2773-pseudo-io-serialization
branch
from
a5fc43c
to
10065bf
Compare
flavorjones
force-pushed
the
2773-pseudo-io-serialization
branch
from
10065bf
to
5e49ded
Compare
and make sure we're using the BOM correctly
flavorjones
force-pushed
the
2773-pseudo-io-serialization
branch
from
5e49ded
to
952ff44
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What problem is this PR intended to solve?
#2773
Serializing documents now works again with pseudo-IO objects that don't support IO's encoding API (like rubyzip's
Zip::OutputStream). This was a regression in v1.14.0 due to the fix for #752 in #2434, and was not completely fixed by #2753. [#2773]Have you included adequate test coverage?
Yes, existing coverage was extended to include JRuby, and new coverage was added for this case.
Does this change affect the behavior of either the C or the Java implementations?
This restores CRuby behavior to parity with the previous behavior that matches JRuby.