Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dep(dev): pin psych to v4 until v5 builds in CI (backport) #2717

Merged
merged 2 commits into from Dec 6, 2022
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
1 change: 1 addition & 0 deletions nokogiri.gemspec
Expand Up @@ -325,6 +325,7 @@ Gem::Specification.new do |spec|
spec.add_development_dependency("hoe-markdown", "~> 1.4")
spec.add_development_dependency("minitest", "~> 5.15")
spec.add_development_dependency("minitest-reporters", "~> 1.4")
spec.add_development_dependency("psych", "~> 4.0") # psych 5 isn't building in places yet https://github.com/ruby/setup-ruby/issues/409
spec.add_development_dependency("rake", "~> 13.0")
spec.add_development_dependency("rake-compiler", "= 1.1.7")
spec.add_development_dependency("rake-compiler-dock", "= 1.2.2")
Expand Down
2 changes: 1 addition & 1 deletion test/xml/sax/test_parser.rb
Expand Up @@ -402,7 +402,7 @@ def call_parse_io_with_encoding(encoding)
end

it :test_large_cdata_is_handled do
skip("see #2132 and https://gitlab.gnome.org/GNOME/libxml2/-/issues/200") if Nokogiri.uses_libxml?("<=2.9.10")
skip("see #2132 and https://gitlab.gnome.org/GNOME/libxml2/-/issues/200") if Nokogiri::VersionInfo.instance.libxml2_using_system?

template = <<~EOF
<?xml version="1.0" encoding="UTF-8"?>
Expand Down