ci: run bash scripts on windows runners #2659
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
OK, these 4 remaining failures are real failures when building from source on Windows, I think. Grr. |
flavorjones
force-pushed
the
flavorjones-try-bash-on-windows-runners
branch
from
a7c7a7c
to
5a5388c
Compare
flavorjones
changed the title
flavorjones
force-pushed
the
flavorjones-try-bash-on-windows-runners
branch
from
5a5388c
to
5b57929
Compare
|
I think I've fixed the failures, which were compiling-nokogumbo-against-nokogiri-built-with-system-libraries. |
flavorjones
force-pushed
the
flavorjones-try-bash-on-windows-runners
branch
2 times, most recently
from
ac0d74d
to
f5e45d3
Compare
|
Still struggling to get the nokogumbo integration test to not fail during linktime. Relevant prior work is at #2167 |
flavorjones
force-pushed
the
flavorjones-try-bash-on-windows-runners
branch
2 times, most recently
from
add545a
to
b79f989
Compare
specify ldflags to resolve Nokogiri's symbols.
flavorjones
force-pushed
the
flavorjones-try-bash-on-windows-runners
branch
from
b79f989
to
f461f9e
Compare
|
Ugh, it's because Nokogumbo 2.0.4 doesn't have the fixes for the linked flags! 🤦 OK, should be green now. |
flavorjones
force-pushed
the
flavorjones-try-bash-on-windows-runners
branch
from
f461f9e
to
bec9da5
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What problem is this PR intended to solve?
Run the full test suite against the installed gems on windows systems.