Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: XML::Reader XML::Attr garbage collection #2599

Merged
merged 4 commits into from Jul 22, 2022
Merged

fix: XML::Reader XML::Attr garbage collection #2599

merged 4 commits into from Jul 22, 2022

Commits on Jul 21, 2022

  1. ci: add creek to the downstream pipeline

    @flavorjones
    flavorjones committed Jul 21, 2022
    Copy the full SHA
    30a2e67 View commit details
    Browse the repository at this point in the history

  2. feat: Reader#attribute_hash 

    which is now being used to implement Reader#attributes

fix: Reader#namespaces on JRuby now returns an empty hash when no
attributes are present (previously returned nil)
    @flavorjones
    flavorjones committed Jul 21, 2022
    Copy the full SHA
    5e65d09 View commit details
    Browse the repository at this point in the history

  3. dev: introduce NOKO_WARN_DEPRECATION macro 

    which will use rb_category_warning if it's available, and rb_warning
if it's not
    @flavorjones
    flavorjones committed Jul 21, 2022
    Copy the full SHA
    dc202ed View commit details
    Browse the repository at this point in the history

  4. deprecate: Reader#attribute_nodes 

    This method will be removed in a future version
    @flavorjones
    flavorjones committed Jul 21, 2022
    Copy the full SHA
    113440c View commit details
    Browse the repository at this point in the history