Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

jruby: use a modern c14n library #2547

Draft
wants to merge 3 commits into
base: main
Choose a base branch
from
Draft
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
2 changes: 2 additions & 0 deletions ext/java/nokogiri/NokogiriService.java
Expand Up @@ -92,6 +92,8 @@ public class NokogiriService implements BasicLibraryService
createSaxModule(ruby, xmlSaxModule, htmlSaxModule);
createXsltModule(ruby, xsltModule);
nokogiri.setInternalVariable("cache", populateNokogiriClassCahce(ruby));

org.apache.xml.security.Init.init();
}

private void
Expand Down
18 changes: 9 additions & 9 deletions ext/java/nokogiri/XmlDocument.java
Expand Up @@ -8,6 +8,7 @@
import static nokogiri.internals.NokogiriHelpers.stringOrNil;

import java.util.List;
import java.io.ByteArrayOutputStream;

import javax.xml.parsers.DocumentBuilderFactory;
import javax.xml.parsers.ParserConfigurationException;
Expand Down Expand Up @@ -36,13 +37,13 @@
import org.w3c.dom.Node;
import org.w3c.dom.NodeList;

import org.apache.xml.security.exceptions.XMLSecurityException;
import org.apache.xml.security.c14n.Canonicalizer;

import nokogiri.internals.NokogiriHelpers;
import nokogiri.internals.NokogiriNamespaceCache;
import nokogiri.internals.SaveContextVisitor;
import nokogiri.internals.XmlDomParserContext;
import nokogiri.internals.c14n.CanonicalFilter;
import nokogiri.internals.c14n.CanonicalizationException;
import nokogiri.internals.c14n.Canonicalizer;

/**
* Class for Nokogiri::XML::Document
Expand Down Expand Up @@ -673,15 +674,14 @@ private static class DocumentBuilderFactoryHolder
try {
Canonicalizer canonicalizer = Canonicalizer.getInstance(algorithmURI);
XmlNode startingNode = getStartingNode(block);
byte[] result;
CanonicalFilter filter = new CanonicalFilter(context, block);
ByteArrayOutputStream writer = new ByteArrayOutputStream();
if (inclusive_namespace == null) {
result = canonicalizer.canonicalizeSubtree(startingNode.getNode(), filter);
canonicalizer.canonicalizeSubtree(startingNode.getNode(), writer);
} else {
result = canonicalizer.canonicalizeSubtree(startingNode.getNode(), inclusive_namespace, filter);
canonicalizer.canonicalizeSubtree(startingNode.getNode(), inclusive_namespace, writer);
}
return RubyString.newString(context.runtime, new ByteList(result, UTF8Encoding.INSTANCE));
} catch (Exception e) {
return RubyString.newString(context.runtime, writer.toString());
} catch (XMLSecurityException e) {
throw context.getRuntime().newRuntimeError(e.getMessage());
}
}
Expand Down
122 changes: 0 additions & 122 deletions ext/java/nokogiri/internals/c14n/AttrCompare.java

This file was deleted.

178 changes: 0 additions & 178 deletions ext/java/nokogiri/internals/c14n/C14nHelper.java

This file was deleted.