Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dep: update libxml2 to v2.9.14 (main branch) #2526

Merged
merged 2 commits into from May 4, 2022

Conversation

flavorjones
Copy link
Member

@flavorjones flavorjones commented May 2, 2022

What problem is this PR intended to solve?

Update libxml2 to v2.9.14 rom v2.9.13, see #2525

https://gitlab.gnome.org/GNOME/libxml2/-/releases/v2.9.14

Also ensure that tests pass against upstream libxml2 (#2468).

Have you included adequate test coverage?

This PR updates tests to reflect the difference in how incorrectly-opened comments are handled in this release.

Does this change affect the behavior of either the C or the Java implementations?

The C native implementation handling of incorrectly-opened comments is different from previous and different from the JRuby implementation's handling. These differences are fully captured and explained in the test suite.

@flavorjones flavorjones force-pushed the 2525-update-libxml-2_9_14-main branch from ccfc287 to 5c984cf Compare May 2, 2022 22:21
@flavorjones flavorjones added upstream/libxml2 dependencies Pull requests that update a dependency file labels May 2, 2022
@flavorjones flavorjones mentioned this pull request May 2, 2022
8 tasks
@flavorjones flavorjones force-pushed the 2525-update-libxml-2_9_14-main branch 2 times, most recently from baa6453 to d122437 Compare May 4, 2022 12:28
A few fixes, including ones by your truly, have made it upstream (but
not yet in a release) and the tests' conditional logic is being
updated.

Closes #2468
@flavorjones flavorjones force-pushed the 2525-update-libxml-2_9_14-main branch from d122437 to 3ed5bf2 Compare May 4, 2022 14:04
@flavorjones flavorjones merged commit c9b9201 into main May 4, 2022
@flavorjones flavorjones deleted the 2525-update-libxml-2_9_14-main branch May 4, 2022 15:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file upstream/libxml2
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant