Fix namespace reparenting issue #2494. #2495
Open
+46
−5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TreyE
changed the title
TreyE
force-pushed
the
issue_2494
branch
3 times, most recently
from
ff0357e
to
3b4c926
Compare
|
I've kicked off CI. |
flavorjones
force-pushed
the
issue_2494
branch
from
3b4c926
to
c3e6b7e
Compare
|
I've rebased onto current |
|
Looks like this PR breaks some downstream users of Nokogiri. Would you be able to take a look at what's going on there, please? |
|
I think I might be able to take a look, yeah. Let me see which ones get broken. I couldn't find any breaks in the main tests but maybe I didn't run some. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What problem is this PR intended to solve?
This PR is intended to address #2494, issues with the reparenting of nodes with prefix collisions.
Closes #2494
Have you included adequate test coverage?
I've added a test as part of the namespace testing under
test/xml/test_namespace.rb.Does this change affect the behavior of either the C or the Java implementations?
C implementations are corrected, the java implementation does not suffer from this issue (tests pass correctly with no code change).