fix: revert libxml2 regression with HTML4 recovery #2462
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
flavorjones
force-pushed
the
2461-html4-recovery-start-tag
branch
from
9530da8
to
16b4fa2
Compare
5 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What problem is this PR intended to solve?
Fixes #2461 by reverting the relevant upstream commit in libxml2.
Have you included adequate test coverage?
Yes, this PR includes additional test coverage for start tag recovery by the HTML4 parser.
Does this change affect the behavior of either the C or the Java implementations?
This keeps the HTML4 parser behavior identical in both CRuby and JRuby implementations (they diverged in v1.13.2 due to #2461).