Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: regression with XPath attributes in CSS selectors #2422

Merged
merged 7 commits into from Jan 13, 2022
Merged

fix: regression with XPath attributes in CSS selectors #2422

merged 7 commits into from Jan 13, 2022

Commits on Jan 12, 2022

  1. test: wrap CSS integration tests in a describe 

    so it's easier to do focused test runs
    @flavorjones
    flavorjones committed Jan 12, 2022
    Configuration menu
    Copy the full SHA
    0744d00 View commit details
    Browse the repository at this point in the history

  2. style: reformat parser.y

    @flavorjones
    flavorjones committed Jan 12, 2022
    Configuration menu
    Copy the full SHA
    269853e View commit details
    Browse the repository at this point in the history

  3. fix: regression with XPath attributes in CSS selectors 

    This commit removes "@" from the IDENT token so that we can create a
new grammar rule in the parser for XPath attributes.

Fixes #2419
    @flavorjones
    flavorjones committed Jan 12, 2022
    Configuration menu
    Copy the full SHA
    8f80cfd View commit details
    Browse the repository at this point in the history

  4. refactor: extract xpath visitor html5 namespace handling logic

    @flavorjones
    flavorjones committed Jan 12, 2022
    Configuration menu
    Copy the full SHA
    a1c34b3 View commit details
    Browse the repository at this point in the history

  5. refactor: CSS parser AST uses :ATTRIB_NAME nodes consistently 

    All attribute references end up as an :ATTRIB_NAME node without the
"@" present, which simplifies the XPath visitor code.
    @flavorjones
    flavorjones committed Jan 12, 2022
    2 Configuration menu
    Copy the full SHA
    b5a50f8 View commit details
    Browse the repository at this point in the history

  6. style: collapse whitespace in css/parser.y

    @flavorjones
    flavorjones committed Jan 12, 2022
    Configuration menu
    Copy the full SHA
    855a812 View commit details
    Browse the repository at this point in the history

  7. doc: improve Searchable#css documentation 

    And officially document the XPath attribute extensions to CSS selector
syntax that we support.

See #2419 for context
    @flavorjones
    flavorjones committed Jan 12, 2022
    Configuration menu
    Copy the full SHA
    538e11d View commit details
    Browse the repository at this point in the history