fix: regression in XSLT.quote_params handling non-strings #2420
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Along the way, rewrite this method, refactor the tests, and improve the documentation. Closes #2418
flavorjones
force-pushed
the
2418-xslt-quote-params-nonstring-param
branch
from
7e84cd8
to
cc6ff71
Compare
|
backport to v1.13.x at #2421 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What problem is this PR intended to solve?
Along the way, rewrite this method, refactor the tests, and improve
the documentation.
Closes #2418
Have you included adequate test coverage?
Yes!
Does this change affect the behavior of either the C or the Java implementations?
No.