use the correct classes for fragment parsing #2388
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
flavorjones
changed the title
flavorjones
force-pushed
the
1158-use-the-right-classes
branch
2 times, most recently
from
4a23e2c
to
2d02024
Compare
Introduce ClassResolver which will do the class lookup correctly, and use it for Builder and for fragment parsing. Closes #1158
flavorjones
force-pushed
the
1158-use-the-right-classes
branch
from
2d02024
to
38c2f16
Compare
This was referenced Oct 1, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What problem is this PR intended to solve?
#1158 reported a bug whose root cause is the use of incorrect class (Nokogiri::HTML4::DocumentFragment instead of Nokogiri::XML::DocumentFragment) during fragment parse error recovery.
This PR introduces a new mixin,
Nokogiri::ClassResolverfor the few places in the codebase where an appropriate class needs to be chosen. (For example, a node in aNokogiri::XML::Documentneeding to use the relatedDocumentFragmentclass.)ClassResolveris now used for fragment parsing as well asBuilderdocument creation.Have you included adequate test coverage?
Yes!
Does this change affect the behavior of either the C or the Java implementations?
No.