Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add tests to cover line numbering edge cases with JRuby #2379

Merged
merged 5 commits into from Dec 22, 2021
Merged

Add tests to cover line numbering edge cases with JRuby #2379

merged 5 commits into from Dec 22, 2021

Commits on Dec 22, 2021

  1. Add tests to cover line numbering edge cases with JRuby

    @dabdine @flavorjones
    dabdine authored and flavorjones committed Dec 22, 2021
    Configuration menu
    Copy the full SHA
    ca200c5 View commit details
    Browse the repository at this point in the history

  2. test: mark the jruby tests from sparklemotion#2379 as pending 

    See context in sparklemotion#2380. The fix on JRuby is expensive and is probably
not worth the investment of developer time right now.

But let's preserve those failures as a known issue by introducing the
`pending` and `pending_if` test helpers.
    @flavorjones
    flavorjones committed Dec 22, 2021
    Configuration menu
    Copy the full SHA
    469163e View commit details
    Browse the repository at this point in the history

  3. fix: jruby Node#line counts multiline comments correctly

    @flavorjones
    flavorjones committed Dec 22, 2021
    Configuration menu
    Copy the full SHA
    d08025c View commit details
    Browse the repository at this point in the history

  4. style: clean up xml/test_node.rb

    @flavorjones
    flavorjones committed Dec 22, 2021
    Configuration menu
    Copy the full SHA
    d08f118 View commit details
    Browse the repository at this point in the history

  5. fix(jruby): Node#line returns position in the final DOM 

    - document this difference from CRuby/libxml2
- add 1 to account for the prolog
- update tests to explicitly specify this difference
    @flavorjones
    flavorjones committed Dec 22, 2021
    Configuration menu
    Copy the full SHA
    aae6ede View commit details
    Browse the repository at this point in the history