feat(CRuby): XML::Reader#encoding returns detected enc when not set #2377
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
flavorjones
force-pushed
the
980-reader-encoding-detection
branch
from
f9ac835
to
ab5bcf6
Compare
Previously this always and only returned the encoding passed to the constructor. Now, if no encoding is passed to the constructor, then Reader#encoding will return the encoding detected by the parser. Note that this has not been implemented for JRuby.
flavorjones
force-pushed
the
980-reader-encoding-detection
branch
from
ab5bcf6
to
4590844
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What problem is this PR intended to solve?
Closes #980
Previously Reader#encoding always and only returned the encoding passed to the
constructor. Now, if no encoding is passed to the constructor, then
Reader#encoding will return the encoding detected by the parser.
Have you included adequate test coverage?
Yes.
Does this change affect the behavior of either the C or the Java implementations?
Note that this has not been implemented for JRuby.