Fix XML::Builder not handling exceptions safely - 2372 #2373
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: Joana Tavares <jtavares@salsify.com>
Co-authored-by: Joana Tavares <jtavares@salsify.com>
ric2b
changed the title
flavorjones
approved these changes
Nov 19, 2021
|
I'll wait for CI to go green before merging. |
|
Please ignore the Windows Ruby 2.5 failures - they're unrelated and I'm investigating at #2354 |
|
I've added a commit to this PR that updates the CHANGELOG with a thank-you to both @ric2b and @rinthedev |
|
And thanks for looking at it so quickly! :) |
|
Merged! Will ship in the next release (not sure yet whether that will be 1.12.6 or 1.13.0) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What problem is this PR intended to solve?
#2372
Have you included adequate test coverage?
I think so.
Does this change affect the behavior of either the C or the Java implementations?
Yes, since this changes non-platform specific code.
Co-authored-by: Joana Tavares jtavares@salsify.com