Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix JRuby SAX parser entity handling (v1.12.x backport) #2329

Merged
merged 3 commits into from Sep 26, 2021
Merged

fix JRuby SAX parser entity handling (v1.12.x backport) #2329

merged 3 commits into from Sep 26, 2021

Commits on Sep 26, 2021

  1. format: test files 

    - xml/sax/test_parser.rb
- xml/sax/test_push_parser.rb
    @flavorjones
    flavorjones committed Sep 26, 2021
    Copy the full SHA
    2790122 View commit details
    Browse the repository at this point in the history

  2. refactor(jruby): handle errors more consistently 

    NokogiriErrorHandler stores RubyException but also accepts (and
type-converts) Exception and RaiseException.

NokgiriHandler uses NokogiriErrorHandler under the hood.

NokogiriErrorHandler classes use addError consistently everywhere.
    @flavorjones
    flavorjones committed Sep 26, 2021
    Copy the full SHA
    f943ee4 View commit details
    Browse the repository at this point in the history

  3. fix(jruby): SAX parser uses an entity resolver 

    to avoid XXE injections.

This behavior now matches the CRuby implementation.
    @flavorjones
    flavorjones committed Sep 26, 2021
    Copy the full SHA
    4bd943c View commit details
    Browse the repository at this point in the history