Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: HTML4::Document.to_xhtml self-closing tags (v1.12.x) #2327

Merged
merged 1 commit into from Sep 24, 2021
Merged

fix: HTML4::Document.to_xhtml self-closing tags (v1.12.x) #2327

merged 1 commit into from Sep 24, 2021

Commits on Sep 23, 2021

  1. fix: HTML4::Document.to_xhtml self-closing tags 

    Commit 1d06b4f introduced NO_EMPTY_TAGS into
SaveOptions::DEFAULT_XHTML which libxml2 ignored due to a
long-standing bug in serialization.

libxml2 v2.9.11 fixed that serialization bug
(https://gitlab.gnome.org/GNOME/libxml2/-/commit/dc6f009) and started
paying attention to the NO_EMPTY_TAGS save option, resulting in seeing
output containing, e.g. `<col></col>` instead of `<col/>`.

This commit updates the default XHTML save options to drop the
NO_EMPTY_TAGS flag, restoring this behavior.

Closes #2324
    @flavorjones
    flavorjones committed Sep 23, 2021
    Copy the full SHA
    a0180c7 View commit details
    Browse the repository at this point in the history