Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Restore Builder namespace inheritance behavior, and introduce Document#namespace_inheritance #2320

Merged
merged 3 commits into from Aug 29, 2021
Merged

Restore Builder namespace inheritance behavior, and introduce Document#namespace_inheritance #2320

merged 3 commits into from Aug 29, 2021

Commits on Aug 29, 2021

  1. feat/fix: introduce Document#namespace_inheritance attr 

    When true, reparented elements without a namespace will inherit their
new parent's namespace (if one exists). Defaults to +false+.

This is part of addressing the behavior change introduced in v1.12 by
1f483f0, allowing us to switch it on or off per-document. See #2317.
    @flavorjones
    flavorjones committed Aug 29, 2021
    Copy the full SHA
    6cc477c View commit details
    Browse the repository at this point in the history

  2. feat/fix: re-enable namespace_inheritance for Builder documents 

    This restores the Builder behavior from Nokogiri versions before
1.12.0. This can be switched off by passing a kwarg to the Builder
initializer. See #2317.
    @flavorjones
    flavorjones committed Aug 29, 2021
    Copy the full SHA
    784934f View commit details
    Browse the repository at this point in the history

  3. update CHANGELOG

    @flavorjones
    flavorjones committed Aug 29, 2021
    Copy the full SHA
    59cd533 View commit details
    Browse the repository at this point in the history