Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

clean up XML::Schema #2316

Draft
wants to merge 4 commits into
base: main
Choose a base branch
from
Draft

Conversation

flavorjones
Copy link
Member

@flavorjones flavorjones commented Aug 24, 2021

What problem is this PR intended to solve?

This branch is a WIP addressing several issues with Schema.

On branch:

Planned for branch but not yet there:

Have you included adequate test coverage?

... in progress ...

Does this change affect the behavior of either the C or the Java implementations?

  • Makes the two implementations consistent in how errors are handled by #validate and #valid?
  • ... in progress ...

@flavorjones flavorjones force-pushed the flavorjones-clean-up-xml-schema branch from 193d506 to f415cbd Compare November 22, 2021 22:34
@flavorjones
Copy link
Member Author

Rebased.

@flavorjones flavorjones force-pushed the flavorjones-clean-up-xml-schema branch from f415cbd to 85d0570 Compare November 23, 2021 01:52
@flavorjones flavorjones added this to the v1.14.0 milestone Jun 5, 2022
@flavorjones flavorjones modified the milestones: v1.14.0, v1.15.0 Aug 28, 2022
@flavorjones flavorjones modified the milestones: v1.15.0, v1.16.0 Apr 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Nokogiri::XML::Schema#validate behaves differently in MRI and JRuby
1 participant