Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ext: load C extension files from non-native gems via "require" #2301

Merged
merged 1 commit into from Aug 4, 2021
Merged

ext: load C extension files from non-native gems via "require" #2301

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
7 changes: 6 additions & 1 deletion lib/nokogiri/extension.rb
View file
Open in desktop
Expand Up @@ -2,6 +2,7 @@

# load the C or Java extension
begin
# native precompiled gems package shared libraries in <gem_dir>/lib/nokogiri/<ruby_version>
::RUBY_VERSION =~ /(\d+\.\d+)/
require_relative "#{Regexp.last_match(1)}/nokogiri"
rescue LoadError => e
Expand All @@ -22,5 +23,9 @@
EOM
raise e
end
require_relative "nokogiri"

# use "require" instead of "require_relative" because non-native gems will place C extension files
# in Gem::BasicSpecification#extension_dir after compilation (during normal installation), which
# is in $LOAD_PATH but not necessarily relative to this file (see #2300)
require "nokogiri/nokogiri"
end