Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix BSD support for libgumbo #2299

Merged
merged 4 commits into from Aug 3, 2021
Merged

fix BSD support for libgumbo #2299

merged 4 commits into from Aug 3, 2021

Commits on Aug 3, 2021

  1. test: add freebsd to the vagrantfile for testing 

    Related to #2298
    @flavorjones
    flavorjones committed Aug 3, 2021
    Copy the full SHA
    6e87b67 View commit details
    Browse the repository at this point in the history

  2. ci: add coverage for freebsd

    @flavorjones
    flavorjones committed Aug 3, 2021
    Copy the full SHA
    66dace2 View commit details
    Browse the repository at this point in the history

  3. ext(gumbo): Makefile variable override is not necessary 

    since 5c6f7c1 when we started passing CFLAGS, et al through
environment variables instead of through the make command line.

Although this wasn't doing any harm on gnu-based systems, `override`
is a gnu-ism and we need to support builds on bsd systems.

Related to #2298
    @flavorjones
    flavorjones committed Aug 3, 2021
    Copy the full SHA
    2e7ab22 View commit details
    Browse the repository at this point in the history

  4. ext(gumbo): avoid Gnu-isms in the Makefile 

    The wildcard and patsubst functions, as well as $^, don't work in BSD
make. Let's just inline everything to make it simple and portable.

Related to #2298
    @flavorjones
    flavorjones committed Aug 3, 2021
    Copy the full SHA
    1159a9b View commit details
    Browse the repository at this point in the history