Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Resolve potential NPE in SchemaResourceResolver #2296

Merged
merged 3 commits into from Aug 19, 2021
Merged

Resolve potential NPE in SchemaResourceResolver #2296

merged 3 commits into from Aug 19, 2021

Commits on Aug 18, 2021

  1. test: move the test from 3c95d44 to be within a test class 

    I don't think this test ever actually ran.
    @flavorjones
    flavorjones committed Aug 18, 2021
    Copy the full SHA
    5840d84 View commit details
    Browse the repository at this point in the history

  2. test: repro for sparklemotion#2296

    @flavorjones
    flavorjones committed Aug 18, 2021
    Copy the full SHA
    dc61332 View commit details
    Browse the repository at this point in the history

  3. Resolve potential NPE in SchemaResourceResolver 

    The LSResourceResolver interface specifies that the systemId parameter may be null. The SchemaResourceResolver uses this argument without checking for this which can result a NullPointerException. This patch adds an extra null check before using the parameter.
    @pepijnve @flavorjones
    pepijnve authored and flavorjones committed Aug 18, 2021
    Copy the full SHA
    88911fe View commit details
    Browse the repository at this point in the history