Remove the default allocator function from Document #2242
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Code Climate has analyzed commit 16ecfc0 and detected 0 issues on this pull request. The test coverage on the diff in this pull request is 100.0% (80% is the threshold). This pull request will bring the total coverage in the repository to 93.2% (0.0% change). View more on Code Climate. |
|
Windows tests are failing because of #2241 which I'm working on |
|
Chatted with @tenderlove and it sounds like we want to put this into draft mode until all the C-struct classes either define allocate or undef it. |
We expect that XML documents will be of type T_DATA as they are backed by a C extension. It was possible for people to call `allocate` on Document and end up with a T_OBJECT. This commit removes the default allocator so the only way to get a document object is via the constructors we've defined.
flavorjones
force-pushed
the
no-doc-allocation
branch
from
16ecfc0
to
8fa374b
Compare
|
I've rebased which should address the failing windows tests. |
|
Superseded by #2249 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We expect that XML documents will be of type T_DATA as they are backed
by a C extension. It was possible for people to call
allocateonDocument and end up with a T_OBJECT. This commit removes the default
allocator so the only way to get a document object is via the
constructors we've defined.