test: adjust tests to pass on system libxml2 >= 2.9.11, and work around windows dll unloading issue #2240
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
because the comment parsing improvement was merged upstream.
|
Code Climate has analyzed commit 3ceecf3 and detected 0 issues on this pull request. The test coverage on the diff in this pull request is 100.0% (80% is the threshold). This pull request will bring the total coverage in the repository to 93.2% (0.0% change). View more on Code Climate. |
flavorjones
force-pushed
the
flavorjones-update-tests-to-work-with-system-libxml-2_9_12
branch
from
942d38f
to
3ceecf3
Compare
flavorjones
changed the title
flavorjones
deleted the
flavorjones-update-tests-to-work-with-system-libxml-2_9_12
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What problem is this PR intended to solve?
Adjust tests to pass on system libxml2 >= 2.9.11, because the comment parsing improvement was merged upstream. See https://gitlab.gnome.org/GNOME/libxml2/-/merge_requests/82 for context (and the recently removed
htmlParseCommentpatch). This will allow us to run tests regularly against upstream master.Also, work around the libxml2 issue described in #2241 by having libxml2 use its default memory management on windows when system libraries are being used. Note that this also introduces a new value into
Nokogiri::VERSION_INFO, which is "libxml → memory_management", and the value will be either "ruby" or "default".