Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: ensure namespaced attributes are reparented properly #2230

Merged
merged 5 commits into from May 11, 2021
Merged

fix: ensure namespaced attributes are reparented properly #2230

merged 5 commits into from May 11, 2021

Commits on May 11, 2021

  1. update CHANGELOG

    @flavorjones
    flavorjones committed May 11, 2021
    Configuration menu
    Copy the full SHA
    e5ec30b View commit details
    Browse the repository at this point in the history

  2. style: update C/Java format to indent case switches

    @flavorjones
    flavorjones committed May 11, 2021
    Configuration menu
    Copy the full SHA
    dad8728 View commit details
    Browse the repository at this point in the history

  3. test: add coverage for attribute namespace after reparenting 

    also use xmlNodePtr->properties in place of xmlElementPtr->attributes
because it's clearer and requires less type gymnastics
    @flavorjones
    flavorjones committed May 11, 2021
    Configuration menu
    Copy the full SHA
    8f69859 View commit details
    Browse the repository at this point in the history

  4. chore: remove an unneeded xmlSetNs-after-reparent call 

    The function `reparent_node_with` is already doing the right thing.
    @flavorjones
    flavorjones committed May 11, 2021
    Configuration menu
    Copy the full SHA
    1f483f0 View commit details
    Browse the repository at this point in the history

  5. fix: ensure namespaced attributes are reparented properly 

    Previously, the namespace was dropped from the attribute.

Fixes #2228

Co-authored-by: Nikolaj Potashnikoff <34554890+fiddlededee@users.noreply.github.com>
    @flavorjones @fiddlededee
    flavorjones and fiddlededee committed May 11, 2021
    Configuration menu
    Copy the full SHA
    cd6941f View commit details
    Browse the repository at this point in the history