Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix nokogumbo linking on windows #2202

Merged
merged 5 commits into from Mar 8, 2021
Merged

fix nokogumbo linking on windows #2202

merged 5 commits into from Mar 8, 2021

Commits on Mar 7, 2021

  1. fix: ensure_func fails properly if it fails during build

    @flavorjones
    flavorjones committed Mar 7, 2021
    Configuration menu
    Copy the full SHA
    b99ecb8 View commit details
    Browse the repository at this point in the history

  2. fix(windows): ensure libxml2 symbols are exported from nokogiri.so 

    Related to #2167
Related to rubys/nokogumbo#163
    @flavorjones
    flavorjones committed Mar 7, 2021
    Configuration menu
    Copy the full SHA
    7ace791 View commit details
    Browse the repository at this point in the history

  3. fix(windows): ensure nokogiri symbols are exported from nokogiri.so 

    Related to #2167
Related to rubys/nokogumbo#163
    @flavorjones
    flavorjones committed Mar 7, 2021
    Configuration menu
    Copy the full SHA
    bb7cab7 View commit details
    Browse the repository at this point in the history

  4. fix(windows): version info contains ldflags on windows 

    to allow downstream gems like nokogumbo to build correctly simply by
requiring nokogiri in the extconf and running:

  append_cflags(Nokogiri::VERSION_INFO["nokogiri"]["cppflags"])
  append_ldflags(Nokogiri::VERSION_INFO["nokogiri"]["ldflags"])

this is needed because unresolved symbols aren't allowed on windows.

Related to #2167
    @flavorjones
    flavorjones committed Mar 7, 2021
    Configuration menu
    Copy the full SHA
    1b448d7 View commit details
    Browse the repository at this point in the history

  5. doc: update CHANGELOG and add a VersionInfo comment

    @flavorjones
    flavorjones committed Mar 7, 2021
    Configuration menu
    Copy the full SHA
    3cff820 View commit details
    Browse the repository at this point in the history