Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow overriding env var with --use-system-libraries=false and default to --disable-static on TruffleRuby #2193

Merged
merged 5 commits into from Mar 11, 2021
Merged

Allow overriding env var with --use-system-libraries=false and default to --disable-static on TruffleRuby #2193

merged 5 commits into from Mar 11, 2021

Commits on Mar 9, 2021

  1. doc: punctuate the extconf option help strings.

    @flavorjones
    flavorjones committed Mar 9, 2021
    Copy the full SHA
    b3798ca View commit details
    Browse the repository at this point in the history

  2. feat(build): extconf supports --disable/enable-system-libraries 

    This will be used to override NOKOGIRI_USE_SYSTEM_LIBRARIES and the
--use-system-libraries option (which should eventually be deprecated).

This will allow TruffleRuby users to override the TR default which is
hacked into mkmf.rb.

Co-authored-by: Benoit Daloze <eregontp@gmail.com>
    @flavorjones @eregon
    flavorjones and eregon committed Mar 9, 2021
    Copy the full SHA
    332f74f View commit details
    Browse the repository at this point in the history

  3. refactor: extract extconf config into methods 

    One small step towards a Config object that we can extract.
    @flavorjones
    flavorjones committed Mar 9, 2021
    Copy the full SHA
    fa08f31 View commit details
    Browse the repository at this point in the history

  4. doc: update CHANGELOG with enable/disable-system-libraries

    @flavorjones
    flavorjones committed Mar 9, 2021
    Copy the full SHA
    98bf3a0 View commit details
    Browse the repository at this point in the history

  5. feat(build): default to --disable-static on TruffleRuby 

    * Shared libraries are more flexible and compile faster, see
  sparklemotion#2191 (comment)
* Static libraries can still be chosen (e.g., for testing) with:
  gem install nokogiri -- --use-system-libraries=false --enable-static

Co-authored-by: Benoit Daloze <eregontp@gmail.com>
    @flavorjones @eregon
    flavorjones and eregon committed Mar 9, 2021
    Copy the full SHA
    4a3836e View commit details
    Browse the repository at this point in the history