fix(cruby): patch libxml2 to address GNOME/libxml2#200 #2182
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Also, use skip instead of avoiding test definition.
This patch shrinks the libxml2 input buffer in a few parser functions. Fixes #2132
flavorjones
force-pushed
the
2132-fix-huge-input-lookup-on-large-cdata
branch
from
ec13839
to
e0da4d2
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What problem is this PR intended to solve?
This patch shrinks the libxml2 input buffer in a few parser functions.
Fixes #2132 using the proposed fix for GNOME/libxml2#200 in https://gitlab.gnome.org/GNOME/libxml2/-/merge_requests/100
Have you included adequate test coverage?
Yes, the test case from #2132 is reproduced here and run against JRuby and packaged libxml2 (but not system libxml2).
Does this change affect the behavior of either the C or the Java implementations?
This fixes an edge case in the C implementation that does not exist in the Java implementation.