Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(cruby): SAX and Push parser error handling in the presence of foreign handlers #2169

Merged
merged 5 commits into from Jan 6, 2021
Merged

fix(cruby): SAX and Push parser error handling in the presence of foreign handlers #2169

merged 5 commits into from Jan 6, 2021

Commits on Jan 5, 2021

  1. ci: ensure all tests are running setup

    @flavorjones
    flavorjones committed Jan 5, 2021
    Copy the full SHA
    b682ac5 View commit details
    Browse the repository at this point in the history

Commits on Jan 6, 2021

  1. fix(test): clobber libxml2's global error handler before every test 

    to check that we're setting error handlers everywhere we need to.

Related to #2168
    @flavorjones
    flavorjones committed Jan 6, 2021
    1
    Copy the full SHA
    07459fd View commit details
    Browse the repository at this point in the history

  2. fix(cruby): reset libxml2's error handler in sax and push parsers 

    Note that this change regresses the behavior changed in 771164d which
we'll have to fix in an upcoming commit.

Related to #2168, #87
    @flavorjones
    flavorjones committed Jan 6, 2021
    Copy the full SHA
    35aa88b View commit details
    Browse the repository at this point in the history

  3. fix: restore proper error handling in the SAX push parser 

    originally introduced in 771164d but broken in the recent commits.

This is an incomplete fix. We should adopt this same strategy of
save-and-restore everywhere we set the error handlers.
    @flavorjones
    flavorjones committed Jan 6, 2021
    Copy the full SHA
    f9a2c4e View commit details
    Browse the repository at this point in the history

  4. changelog: update for #2168

    @flavorjones
    flavorjones committed Jan 6, 2021
    Copy the full SHA
    bbf850c View commit details
    Browse the repository at this point in the history