Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix the tests in #2080 #2083

Merged
merged 6 commits into from
Oct 13, 2020
Merged

Fix the tests in #2080 #2083

merged 6 commits into from
Oct 13, 2020

Commits on Oct 12, 2020

  1. Add fixture for ISO-8859-1 issue reproduction

    @thbar @flavorjones
    thbar authored and flavorjones committed Oct 12, 2020
    Configuration menu
    Copy the full SHA
    2f1513b View commit details
    Browse the repository at this point in the history

  2. Add reproduction for JRuby regression on ISO-8859-1 content

    @thbar @flavorjones
    thbar authored and flavorjones committed Oct 12, 2020
    Configuration menu
    Copy the full SHA
    1926bf6 View commit details
    Browse the repository at this point in the history

  3. Do not use a default encoding when parsing XML documents. 

    This change fixes the tests in #2080, but introduces more errors.  The errors
are mostly unexpected null encoding when parsing an HTML document.
    @jvshahid @flavorjones
    jvshahid authored and flavorjones committed Oct 12, 2020
    Configuration menu
    Copy the full SHA
    d306fc4 View commit details
    Browse the repository at this point in the history

  4. Use default encoding, instead of null, when parsing HTML docs. 

    This change reduces the number of errors from 23 to 4.
    @jvshahid @flavorjones
    jvshahid authored and flavorjones committed Oct 12, 2020
    Configuration menu
    Copy the full SHA
    8a602ec View commit details
    Browse the repository at this point in the history

  5. Use setStringInputStream instead of setInputStream. 

    This is another place where we pass less information to the Java layer that was
missed in ba16682.
    @jvshahid @flavorjones
    jvshahid authored and flavorjones committed Oct 12, 2020
    Configuration menu
    Copy the full SHA
    763b071 View commit details
    Browse the repository at this point in the history

  6. update CHANGELOG for document encoding fix 

    Related to #2080, #2083
    @flavorjones
    flavorjones committed Oct 12, 2020
    Configuration menu
    Copy the full SHA
    9cf1b35 View commit details
    Browse the repository at this point in the history