Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a workaround for missing call to cross_compile block #2008

Merged
merged 1 commit into from
Mar 22, 2020

Conversation

larskanis
Copy link
Member

The cross_compiling block wasn't called for the x86_64-linux platform, leading to an additional dependency to mini_portile2 and missing post install message.

Related patch to rake-compiler is here: rake-compiler/rake-compiler#171

Fixes #1991

The cross_compiling block wasn't called for the x86_64-linux platform
leading to an additional dependency to mini_portile2 and missing
post install message.

Patch to rake-compiler is here: rake-compiler/rake-compiler#171

Fixes sparklemotion#1991
@flavorjones
Copy link
Member

@larskanis Do you think the change in rake-compiler/rake-compiler#171 will make it into a rake-compiler release sometime soon?

This change, while effective, feels dirty and so I think I'd prefer to bump the dependency in Nokogiri (or even just build locally using rake-compiler master) ... but I don't feel strongly about that.

@larskanis
Copy link
Member Author

@flavorjones IMHO this patch isn't different to other patches we apply to upstream libraries. I'll take care that this issue will be fixed in the next rake-compiler version, but I wouldn't want to block nokogiri until then.

The grpc.gem have had a whole bunch of such patches to the rake-compiler-dock container. In the meantime I solved most of them in the upstream projects (rake-compiler, rake-compiler-dock and ruby), so that only one is left.

@flavorjones flavorjones merged commit e587654 into sparklemotion:master Mar 22, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

precompiled gems should not have a runtime dependency on mini_portile2
2 participants