1692 rebase jack mc add options argument for document fragment #2006
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Thank you for contributing to Nokogiri! To help us prioritize, please take care to answer the questions below when you submit this pull request.
The Nokogiri core team work off of
master
, so please submit all PRs based on themaster
branch. We generally will cherry-pick relevant bug fixes onto the current release branch.What problem is this PR intended to solve?
If there is an existing issue that describes this, feel free to simply link to that issue.
Otherwise, please provide enough context for the Nokogiri maintainers to understand your intent.
Have you included adequate test coverage?
We have a thorough test suite that allows us to create releases confidently and prevent accidental regressions. Any proposed change in behavior must be accompanied by tests.
If possible, please try to write the tests so that they communicate intent.
Does this change affect the C or the Java implementations?
If you're proposing a change to the C implementation, has the behavior change been made to the Java code as well? And vice versa?
If not, that may be OK, just please note it here.