Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

1692 rebase jack mc add options argument for document fragment #2006

Conversation

m305
Copy link

@m305 m305 commented Feb 29, 2020


Thank you for contributing to Nokogiri! To help us prioritize, please take care to answer the questions below when you submit this pull request.

The Nokogiri core team work off of master, so please submit all PRs based on the master branch. We generally will cherry-pick relevant bug fixes onto the current release branch.

What problem is this PR intended to solve?

If there is an existing issue that describes this, feel free to simply link to that issue.

Otherwise, please provide enough context for the Nokogiri maintainers to understand your intent.

Have you included adequate test coverage?

We have a thorough test suite that allows us to create releases confidently and prevent accidental regressions. Any proposed change in behavior must be accompanied by tests.

If possible, please try to write the tests so that they communicate intent.

Does this change affect the C or the Java implementations?

If you're proposing a change to the C implementation, has the behavior change been made to the Java code as well? And vice versa?

If not, that may be OK, just please note it here.

@flavorjones
Copy link
Member

Hi! Please see #1844 for links to related work that I think needs to be done related to #1692. I don't think we need a rebase of PR #1692 at this time, everything is still targetted for a v1.11.0 release.

@flavorjones flavorjones deleted the branch sparklemotion:1959-no-export-libxml2-symbols January 19, 2021 12:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants