Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Drop support for Ruby 2.3 #1917

Closed
wants to merge 1 commit into from
Closed

Drop support for Ruby 2.3 #1917

wants to merge 1 commit into from

Conversation

ashmaroli
Copy link
Contributor

What problem is this PR intended to solve?

Resolves #1886

Have you included adequate test coverage?

Not required.

Does this change affect the C or the Java implementations?

No, this doesn't.

@codeclimate
Copy link

codeclimate bot commented Jul 26, 2019

Code Climate has analyzed commit 3d9ea74 and detected 0 issues on this pull request.

The test coverage on the diff in this pull request is 100.0% (80% is the threshold).

This pull request will bring the total coverage in the repository to 93.8% (0.0% change).

View more on Code Climate.

@fulldecent
Copy link
Contributor

@flavorjones requesting please to add to v1.11.0 at https://github.com/sparklemotion/nokogiri/milestone/18

@flavorjones
Copy link
Member

Hi - thanks much for submitting this PR. Unfortunately, some of the files you're editing here are automatically generated by the dev dependency concourse-gem. I'll take the remaining changes through a manual merge, though.

@flavorjones flavorjones added this to the v1.11.0 milestone Nov 26, 2019
@ashmaroli
Copy link
Contributor Author

@flavorjones No worries. Feel free to close this PR if that would be easier for you.

@flavorjones
Copy link
Member

Manually merged after editing the commit to remove the concourse changes, and credited you in the CHANGELOG. Thanks!

@flavorjones flavorjones mentioned this pull request Jan 11, 2020
Closed
@ashmaroli
Copy link
Contributor Author

Thank you for the mention @flavorjones.

@ashmaroli ashmaroli deleted the drop-ruby2.3-support branch January 12, 2020 05:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fulldecent fulldecent fulldecent approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
v1.11.0
Development

Successfully merging this pull request may close these issues.

Deprecate Ruby 2.3 support
3 participants
@ashmaroli @fulldecent @flavorjones