Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow reparenting nodes to be a child of an empty document #1777

Closed
wants to merge 2 commits into from
Closed

Allow reparenting nodes to be a child of an empty document #1777

wants to merge 2 commits into from

Conversation

jvshahid
Copy link
Member

@jvshahid jvshahid commented Jul 8, 2018

Fixes #1773

@jvshahid jvshahid mentioned this pull request Jul 8, 2018
Closed
@jvshahid jvshahid requested a review from flavorjones July 8, 2018 16:17
@jrochkind
Copy link
Contributor

Thanks for providing a fix for the issue I reported! Any chance of review/merge?

@jvshahid jvshahid closed this Sep 17, 2018
@jvshahid jvshahid deleted the fix-1773 branch September 17, 2018 16:58
@jvshahid jvshahid mentioned this pull request Sep 17, 2018
Merged
@jvshahid
Copy link
Member Author

I merged the fix from #1799 into master. Not sure when the new release will be out. @flavorjones is the one who cuts new releases.

@flavorjones flavorjones added this to the 1.8.5 milestone Oct 4, 2018
@flavorjones
Copy link
Member

Narrator: It was released as part of v1.8.5.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@flavorjones flavorjones Awaiting requested review from flavorjones

Assignees
No one assigned
Labels
platform/jruby
Projects
None yet
Milestone
1.8.5
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@jvshahid @jrochkind @flavorjones